Repository navigation
修正 ESLint 环境阻塞的 WASM 回退判定 - #13
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be347c3ee1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let [config] = configs.as_slice() else { | ||
| return None; | ||
| return Err("eslint_config_selection_unresolved"); |
There was a problem hiding this comment.
When a project uses an unsupported ESLint version without one of these flat-config files—as is typical for an ESLint 8 project using .eslintrc—this early return reports eslint_config_selection_unresolved before inspect_eslint_local_candidate can return local_version_not_supported_by_adapter. The resulting stable task incorrectly tells the user to select a flat config rather than emitting the promised eslint_adapter_version_unsupported guidance to extend the adapter; version/identity classification should therefore occur before config selection.
Useful? React with 👍 / 👎.
1 participant
TypeScript 单文件使用可选 WASM 初检时，已安装但配置歧义、入口为链接或本地包损坏的 ESLint 曾被当作“无原生工具”，从而启动 WASM 并可能产生误导性源码发现。现在原生候选选择明确区分可探测、确实没有本地包、以及环境阻塞；阻塞进入稳定环境任务，保留原生检查义务。适配器不支持项目 ESLint 版本时给出补齐适配器的诊断，不建议更改项目版本。
同步更新 OpenSpec、双语说明和局部验收记录。可选 WASM 仍只覆盖 Java、TypeScript、TSX 的未验收候选；CodeGraph 32 种 grammar 并未全部整合。
验证：19 项定向测试通过，4 项需真实 ESLint 10 的测试忽略；Clippy、格式检查、分层检查及 OpenSpec 严格校验通过。真实 ESLint 10 运行和多模块调度仍待验收。