Repository navigation
接入 TypeScript WASM 初检的稳定原生确认任务 - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f1baf472b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| report["workbench"] = match workspace.canonicalize() { | ||
| Ok(root) if root == *workspace => { | ||
| crate::eslint_workbench::connect_preparation(&root, args, reason) |
There was a problem hiding this comment.
When the source is edited while the WASM worker is running, observe returns observations and source_sha256 for the old bytes, but this call lets eslint_preparation::prepare reread and hash the new bytes without comparing the two digests. Sync can therefore succeed and return a real task ID whose evidence refers to the new source while the same feedback displays suspected positions from the old source; pass the precheck digest/snapshot into preparation or reject the connection when the current digest differs.
Useful? React with 👍 / 👎.
1 participant
启用可选 WASM 初检的 TypeScript/TSX 单文件请求，此前即使指定已初始化工作区，也只返回疑似位置，
workbench=not_connected，无法给智能体一张可复查的稳定任务。现在当项目本地 ESLint 包未观察到时，CLI 复用现有 ESLint 准备报告、同步和next，按工作区与源码范围创建原生确认阻塞任务；仅在同步且任务可读后填入真实setup.task_id。重复初检、源码改动后零恢复节点、以及超出初检预算均不能关闭任务或生成已确认源码 finding。TSX 使用独立 grammar，并确保反馈的next与本次任务 ID 一致。新增封闭的 TypeScript/TSX 0.5.0 反馈 schema，未初始化时沿用旧版 0.3/0.4；同步更新中英文 README、架构技术说明、命令参考、OpenSpec 14.9/14.10 与局部验收记录。
定向回归 21 项通过，4 项真实 ESLint 10 用例因环境缺失而忽略；Clippy、格式、分层与 OpenSpec 严格校验通过。逐个疑似位置的持久关联、能力匹配原生关闭、Java/多模块与宿主对话接入仍未完成；本 PR 不把 14.9/14.10 勾选为完成。