Repository navigation
Pin corrected Zig grammar as Rust WASM candidate - #19
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed CodeGraph inventory was pinned before its Zig empty-container grammar fix, and the new Zig WASM fails to instantiate in Rust because of one unsupported import. This change updates the 32-grammar source inventory to the current CodeGraph commit and adds Zig as a fifth, explicitly unqualified asset candidate. Both the original and adapted Zig bytes are pinned; a narrowly scoped Rust transformation replaces the incompatible import with a same-signature import supported by
WasmStore. The isolated worker now parses legal Zig empty containers without the old grammar's false recovery, while malformed source still produces recovery and no candidate can approve delivery.The OpenSpec and bilingual architecture/technical docs now track all 32 grammar languages as the required target. Feature-enabled legacy workbench tests select the intended task by reason code, preserving the new Python native-confirmation task rather than depending on directory order. This PR does not claim public
lint zig, all-language integration, or released syntax capability;grammar statusstill reports zero released languages.Validation: 30/30 CodeGraph vendored source bytes match the new pinned commit; Zig 0.16.0
fmt --checkaccepts the four empty-container fixtures. Default workspace tests, targeted feature tests, feature-enabled Clippy, OpenSpec strict validation, formatting, layering, and diff checks pass. The full feature-enabled workspace run passed: 180 groups, 1,129 passed, 106 conditionally ignored, zero failed. Default workspace tests also passed. This does not cover the ignored real native-tool cases or release packages.