Repository navigation
接入可重建的 Dart WASM 语法候选 - #26
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeGraph's pinned Dart WASM could not load in the Rust worker because its external scanner import was unresolved. This change rebuilds the parser and real scanner from the pinned upstream commit, applies a byte-pinned WASI import adaptation, and registers Dart as an unqualified grammar candidate.
grammar statusnow distinguishes the original CodeGraph source hash from the rebuilt input and worker asset hashes; it reports 23/32 candidates and 0 released syntax capabilities.The rebuild script reproduces both WASM byte sequences. The pinned upstream corpus has 150 cases whose error classifications match; Rust loader and isolated-worker tests pass without claiming a clean lint result. Parent worker startup now verifies only the selected grammar, removing full-catalog hashing from each single-file observation. CI runs the Dart corpus and loader tests.
Validation:
cargo test --locked --workspace --all-features -- --test-threads=1passed (1146 passed, 106 ignored); targeted grammar/worker tests, Clippy, formatting, OpenSpec strict validation and manifest schema validation passed. A parallel full-suite run still hit two existing Maven probe tests' fixed two-second timeout under load; the isolated Maven probe suite passed. Dart native differential testing, publiclint dart, host feedback and release qualification remain outstanding.