Bump sightmap to v0.26.0; drop dead skill-guidance links - #12
Open
joelgwebber wants to merge 2 commits into
Open
Bump sightmap to v0.26.0; drop dead skill-guidance links#12joelgwebber wants to merge 2 commits into
joelgwebber wants to merge 2 commits into
Conversation
Update github.com/sightmap/sightmap/go from v0.17.0 to v0.26.0 so `sightmap upload` parses .sightmap/ corpora with the current loader and matcher ($ref expansion, view-scoped components, requests/messages/ properties, newer route-matching semantics). No CLI surface change; builds clean and the full test suite (incl. internal/sightmap) passes. Signed-off-by: Joel Webber <joel@fullstory.com>
The "For workflow guidance" links pointed at skill pages that don't exist
(skills/tunnel, and the root help advertised "skill references" that were
never printed). Drop them from `subtext tunnel --help` and the root help,
and fix the stale namespaceHelpFunc doc comment ("+ skill URL"). The live,
server-fetched tool listing in each namespace's --help is the real guidance.
Signed-off-by: Joel Webber <joel@fullstory.com>
joelgwebber
changed the title
jurassix
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two things:
Bump
github.com/sightmap/sightmap/gov0.17.0 → v0.26.0.sightmap upload(viainternal/sightmap'ssm.Load+Corpus.AllComponents) now parses.sightmap/corpora with the current loader and matcher —$refexpansion, view-scoped components, requests/messages/properties, and the newer route-matching semantics. No change to the CLI's own surface or flags.Remove dead skill-guidance links from help text.
subtext tunnel --helpprinted a.../skills/tunnellink, and the root help advertised "skill references" — but those skill pages don't exist (the referenced dirs aren't infullstorydev/subtext). Dropped them and fixed the stalenamespaceHelpFuncdoc comment. The live, server-fetched tool listing in each namespace's--helpis the real, always-current guidance.Builds clean; full test suite (incl.
internal/sightmap,internal/cli) passes. Changeset included (patch).Context
FullStory's internal monorepo carried a fork of this CLI that's now being deleted (an unshipped, orphaned copy). I diffed the two before deleting to port anything the fork had ahead — but there was nothing worth bringing over:
auth/resolve.go— the fork's only diff was a doc comment claimingSECRET_SUBTEXT_API_KEY/FULLSTORY_API_KEYfallbacks the code never actually checked.cli/call.go— this repo is ahead (threadscontext, cleanerrunCalldelegation); the fork'scallCmdindirection is the older shape.cli/help.go— the fork printed per-namespace "workflow guidance" links, but they pointed at nonexistent skill dirs (same class of dead link this PR removes).So retiring the fork loses nothing; this PR is the dep bump plus the small dead-link cleanup.