`.git` suffix inconsistently enforced

[willstott101]

When creating a new repo, a .git suffix is appended here:

node-git-server/src/git.ts

Line 288 in e25c481

if (!/\.git$/.test(repo)) repo += '.git';

and it appears to be enforced in list, but not everywhere

However the .git suffix is not a requirement anywhere else - this server is perfectly happy serving git repositories without a .git suffix afaict...

node-git-server/src/util.ts

Line 150 in e25c481

return repo.slice(0, locationOfGit > 0 ? locationOfGit : repo.length);

This inconsistency has tripped me up a bit. I would personally be in favour of enforcing a .git suffix everywhere - possibly by redirecting to .git suffixed URL if a non-git suffixed URL is encountered.

This is inconsistent with bare/checked-out repo conventions though... which might suggest to enforce .git only if checkout is false...

I think for us we're going to enforce and stick to the suffix externally for the meantime - but it'd be good to gather opinions of other maintainers/users.

[gabrielcsapo]

I agree, we could make this an option that could be "enforceGitSuffix"? Thoughts on what it would look like for opt-in behavior?

[batchor]

This may be fixed in our fork (@batchfy/node-git-server) — see batchfy/node-git-server#1, in case it's useful here.

The approach taken there: every request resolves to one canonical repo name up front, which is then used for the dir resolver, exists(), create() and the emitted events.

• Canonical name is <name>.git for bare repos and <name> when checkout is set, so the checked-out convention is respected (option 3 in the issue).
• A repo that already exists under the requested name wins, so repos stored without the suffix keep working, and both URL forms reach the same repository.
• list() now reports directories that actually are git repositories instead of filtering on the .git suffix.
• enforceGitSuffix: true (per @gabrielcsapo's suggestion above) makes <name>.git the only name a repo is known by: GET requests for a suffix-less URL get a 301 to the .git URL, and non-suffixed directories are neither listed nor served.

Worth noting the pre-existing bugs this surfaced: because create() appended .git while nothing else did, exists() returned false for an existing repo (404 with autoCreate: false, and a redundant git init on every request otherwise), and GET /:repo/HEAD 404'd for a repo that clones fine. It only looked like it worked because git itself resolves repos/doom to repos/doom.git.