Conversation
gagnieray
added this pull request to stack #54
September 30, 2026 20:41
gagnieray
requested changes
Oct 4, 2026
gagnieray
left a comment
gagnieray
left a comment
Member
There was a problem hiding this comment.
I trust you completely regarding the changes related to PostgreSQL 😉
Comment on lines
+21
to
+22
| -- 1.0.0 states were 0 (public donation), 1 (processed), 2 (error), 3 (incomplete) | ||
| -- and 4 (already done); incomplete payments did not create any contribution |
Member
There was a problem hiding this comment.
Suggested change
| -- 1.0.0 states were 0 (public donation), 1 (processed), 2 (error), 3 (incomplete) | |
| -- and 4 (already done); incomplete payments did not create any contribution | |
| -- 1.0.0 states were 0 (none), 1 (processed), 2 (error) and 3 (already | |
| -- done); incomplete payments did not create any contribution |
If I'm not mistaken... See : https://github.com/galette-plugins/plugin-helloasso/pull/26/changes#diff-b0bcc756cebfd17d332ef50d7ef71c614e459acdcc27a5de51e24488ed4f945e
Member
Author
There was a problem hiding this comment.
I think I'm correct. That commit has been added after the 1.0.0 release; the migration script will work withon only <=1.0.0 data - so we must use the old values verbatim.
| WHEN state = 0 THEN 3 | ||
| state = CASE state | ||
| WHEN 0 THEN 3 | ||
| WHEN 3 THEN 2 |
Member
There was a problem hiding this comment.
Suggested change
| WHEN 3 THEN 2 | |
| WHEN 3 THEN 4 |
| WHEN state = 0 THEN 3 | ||
| state = CASE state | ||
| WHEN 0 THEN 3 | ||
| WHEN 3 THEN 2 |
Member
There was a problem hiding this comment.
Suggested change
| WHEN 3 THEN 2 | |
| WHEN 3 THEN 4 |
Comment on lines
+23
to
+24
| -- 1.0.0 states were 0 (public donation), 1 (processed), 2 (error), 3 (incomplete) | ||
| -- and 4 (already done); incomplete payments did not create any contribution |
Member
There was a problem hiding this comment.
Suggested change
| -- 1.0.0 states were 0 (public donation), 1 (processed), 2 (error), 3 (incomplete) | |
| -- and 4 (already done); incomplete payments did not create any contribution | |
| -- 1.0.0 states were 0 (none), 1 (processed), 2 (error) and 3 (already | |
| -- done); incomplete payments did not create any contribution |
Same comment as for upgrade-to-1.0.0-mysql.sql : if I'm not mistaken... See : https://github.com/galette-plugins/plugin-helloasso/pull/26/changes#diff-b0bcc756cebfd17d332ef50d7ef71c614e459acdcc27a5de51e24488ed4f945e
Without it, entries state was never updated and a notification sent again was stored twice.
Test environment sets PDO::ATTR_STRINGIFY_FETCHES, the history page could not be displayed there.
The PostgreSQL script failed on filled tables and on the text request column, previous incomplete state became public, and PostgreSQL loses time of payments and stores amounts as floating point numbers.
trasher
force-pushed
the
feature/functional-fixes
branch
from
October 4, 2026 14:13
0986a44 to
e110339
Compare
Co-authored-by: Guillaume AGNIERAY <107203963+gagnieray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.