Repository navigation
Add gdzig-zlint with the 0.6.1 ruleset - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
gdzig-zlint(ZLint 0.10.0 with the gdzigCODE_STYLErules) and wires itinto mise and CI. Follow-up to gdzig/gdzig#290.
github:gdzig/gdzig-zlint0.6.1 throughmise.tomland updates the tracked lockfile.zlint.jsonunchanged from the 0.6.1 template, preserving all rule levels, including thewarnlevels forgdzig-public-docsandline-length.mise run lintand a Lint workflow for pushes tomain, pull requests, and manual dispatch.hk.pklstep to usegdzig-zlintwithout denying warnings.Verification
gdzig-zlint .: 0 errors, 43 warnings (before: 0 errors, 52 warnings).zig build testwith the repository's locked Zig binary: passes on both the freshmainbaseline and this branch.zig fmt --checkon changed Zig files: passes. The freshmainbaseline also passeszig fmt --check ..mise install && mise run lint: runs successfully (0 errors).mise installre-resolveszig = "master"in the lockfile, so the original Zig 0.17.0-dev.2251+1175a3e99 lock entries were restored afterward.fmt.mdAPI, which would break consumers. None are errors.Notes
--deny-warningsis intentionally not enabled yet because the existing documentation and line length diagnostics still need cleanup.Pre-existing CI failures
The
Testsworkflow'smastermatrix fails on this branch. It is not caused bythis change:
mainalready referencesstd.ArrayListUnmanagedatsrc/tokenizer.zig:129-130andsrc/Node.zig:352, and Zig master0.18.0-dev.567removed that member (error: root source file struct 'std' has no member named 'ArrayListUnmanaged'). Reproduced locally on an unmodifiedmaincheckout with the samezig 0.18.0-dev.567+7f0281900binary:zig build testfails with the identical errors at the same lines. The0.16.0matrixpasses,
build-docspasses, and the newgdzig-zlintjob passes.