refactor(vara.eth): list the RPC role in the node service startup log - #5641
Open
arbelonson-source wants to merge 1 commit into
Open
arbelonson-source wants to merge 1 commit into
arbelonson-source wants to merge 1 commit into
Conversation
The roles line only named Observer and the validator role, so a node serving RPC did not say so at startup. Closes gear-tech#5333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5333
Summary
The startup line only named
Observerand the validator role, so a node serving RPC did not say so. When the RPC server was started,RPCis now appended to the roles list, giving the output the issue expects:How to test
Run
ethexe runwith an RPC port configured and read the⚙️ Node service starting, roles:line; without RPC the line is unchanged.cargo check -p ethexe-servicepasses; the change is log-only, so no test was added.Notes
None.
Checklist
type(scope): description)