Repository navigation
Core: each portfolio tab keeps its own chart periods - #1704
Merged
Merged
Conversation
A late answer for the tab the user left no longer changes the period list or the selected period of the tab on screen. The fallback to an offered period runs only for the tab that is shown, when its answer lands or when the user switches to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Portfolio, an answer for the tab the user had just left could arrive late and switch the period of the chart on screen, for example from 1W to 1D.
Each tab now keeps its own list of periods. A late answer for the other tab is kept for that tab and leaves the visible chart alone. A period the tab does not offer falls back to its first one only when that tab is shown.