Repository navigation
Android: wallet search shows perpetuals in the server's ranking - #1706
Merged
Merged
Conversation
1. Wallet search and list results read the perpetual ranking Core stores for the search key, the same way iOS does: ranked markets first, a list without a ranking has no perpetuals, and a wallet search without one falls back to the text match. 2. Wallet search takes its limit from walletSearchLimits and its key from Core instead of the Perpetuals screen's market query, so the Perpetuals screen keeps its own rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet search on Android ignored the order the server returns for perpetuals. Searching "ethereum" showed no perpetuals, and lists such as Trending showed none at all, while iOS showed both.
Android now reads that ranking the same way iOS does: ranked markets come first, a list without a ranking shows no perpetuals, and a typed search without one falls back to matching names. Wallet search also uses its own result limit instead of the Perpetuals screen's, which stays as it was.
Not checked on iOS: the Trending list, which can only be tested with an injected server response. One difference from iOS remains: when the server sends no ranking, pinned markets come first.