Repository navigation
Core: an ENS name resolves to the address set for the chosen network - #1707
Merged
Merged
Conversation
Read the ENSIP-11 record for the network's coin type instead of the Ethereum address on every EVM network. The resolver applies the owner's default EVM address, and a name without either is not found. Fixes #1692.
alpha.sui no longer has a target address; use aftermath.sui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1692.
An ENS name always resolved to its owner's Ethereum address, whatever EVM network the user sent on:
EnsProviderignored the chain and readaddr(node).gemcoder.ethhas0xBA4D…0AC4for Ethereum,0xD8EB…88EAfor Polygon and BNB Smart Chain, and nothing for Base; sending on Polygon, BNB Smart Chain or Base filled in0xBA4D…. If that address is a smart wallet that doesn't exist on the other network, the funds land where the recipient can't use them.addr(node)(coin type 60). Other EVM networks readaddr(node, coinType)with the ENSIP-11 coin type0x80000000 | chainId(alloy_ens::coin_type::evm_chain)UnsupportedResolverProfile(a resolver without multicoin records) is not found0x80000000) is applied by the resolver, per ENSIP-19, which tells clients not to add their own fallback. Live:gregskril.ethhas only a default record and resolves on Baseresolvehelperdocs/PRODUCT.mdBehavior change: a name with only an Ethereum record is now not found on other EVM networks.
vitalik.ethandnick.ethhave no Polygon, Base or default record, so they no longer resolve there.Also: the SuiNS live test used
alpha.sui, which is still registered but no longer has a target address; it now usesaftermath.sui.Tests: unit tests use
gemcoder.ethresponses captured from mainnet (Polygon record, Base without one). The livename_resolversuite passes 15/15, includinggemcoder.ethon Ethereum, Polygon and Base andgregskril.ethon Base.