remove duplicated flash CSS - #119
Open
Fleeym wants to merge 1 commit into
Open
Conversation
|
As an example, one such issue with the current CSS present in this repo is that, due to the CSS in this repo using the deprecated 
There's a few more minor CSS issues (e.g. scrollbars) but this was really the big one. Good luck looking at the docs unless you make the actual code window pretty small in proportion to docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This duplicated CSS was added a long while ago to prevent "releasing flash versions on CSS updates".
I find that releasing flash versions on CSS updates is useful, though. You improve the design for all users of flash, and they can provide their own version if they want to.
Will also make a PR to geode itself to remove the overwrites from flash.toml