Repository navigation
ci: gate signing jobs behind a release environment and pin actions to commits - #1776
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the release pipeline, from the security audit.
Signing jobs need an approval. The four jobs that use signing or store keys now run in the
releaseenvironment:release-menubar.yml(macOS menubar);build-desktop-mac.yml(macOS desktop);release-menubar-windows.yml(Windows menubar, Tauri updater key);build-snap.yml.The environment already exists. It requires approval from @iamtoruk and only runs from
mainor thev*,mac-v*,windows-v*anddesktop-v*tags. A workflow on any other branch cannot reach it.In
build-snap.ymlthe store upload moves into its ownpublishjob, which downloads the snap artifact. Pull request builds of the snap therefore never wait for an approval.Every action is pinned to a commit. All 48
uses:lines point at the commit their tag resolves to today, with the release in a comment (for exampleactions/checkout@d23441a… # v6.1.0), so nothing runs differently. A moved or hijacked tag can no longer change what runs next to our signing keys. Dependabot's existinggithub-actionsentry keeps the pins current.After merging, the secrets have to move. Environment protection only guards secrets stored in the environment. All 9 signing secrets are repository secrets today, which any workflow on any pushed branch can read. A maintainer has to:
releaseenvironment under the same names, because secret values cannot be copied through the API;Checked: every workflow parses, and
actionlint1.7.12 reports nothing.