Show server-sent errors in the OTP sign in screen - #963
Closed
dividedmind wants to merge 2 commits into
Closed
dividedmind wants to merge 2 commits into
dividedmind wants to merge 2 commits into
Conversation
Integrates getappmap/appmap-js#2396 to display server-generated error messages, providing accurate error information when the server refuses the OTP flow.
There was a problem hiding this comment.
🟢 Approval recommended
The dependency and lockfile updates were fully reviewed with no unresolved issues.
Pull request overview
Updates the webview to consume improved server-sent OTP sign-in error handling.
Changes:
- Bumps
@appland/componentsto4.49.1. - Refreshes dependencies, including
qsandjs-yaml.
File summaries
| File | Description |
|---|---|
appland-webview/yarn.lock |
Records updated dependency resolutions and checksums. |
appland-webview/package.json |
Updates the components dependency. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Integrated in #959 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrates getappmap/appmap-js#2396 to show sign-in errors. Also, bumps qs and js-yaml in the webview.