Skip to content

fix(updates): manual check on an RC ignores newer RCs #1447

Closed

Description

@EtienneLescot

Problem

On a release candidate, Check for Updates says "up to date" even when a newer RC is published.

checkLatestRelease (electron/update-checker.ts) reads releases/latest, which GitHub resolves to the latest stable release and never to a prerelease. Running 2.2.0-rc.1, it got v2.1.2, which is older, and answered "OpenScreen is up to date (2.2.0-rc.1)" while 2.2.0-rc.2 was live.

The startup self-update check (electron-updater) does find the newer RC, because the running version is a prerelease. So the two paths disagree, and the manual button is the one RC testers click.

Observed (v2.2.0-rc.1 → rc.2 e2e, 31/10/2026)

  • macOS, rc.1 official DMG: the manual check reports up to date. The release-page fallback can never trigger on an RC for the same reason.
  • Windows, rc.1 per-machine: the manual check reports up to date. The background check offered "Update to 2.2.0-rc.2" about 70 s after launch.

Expected

When the running version is a prerelease, the manual check also considers prereleases. Stable installs keep reading releases/latest.

Pointers

  • electron/update-checker.ts:1: LATEST_RELEASE_API
  • electron/main.ts checkForUpdates(): calls checkLatestRelease, and only asks electron-updater after a newer version was found

Activity

  1. added
    status: fixed in mainWork is merged into main but may not be in a downloadable release yet.
    status: pending releaseMerged change is waiting for a packaged desktop release.
    on Oct 31, 2026
  2. added this to the Next Release milestone on Oct 31, 2026
  3. github-actions commented on Oct 31, 2026

    @github-actions
    Contributor

    Fixed by #1448 and merged into main.

    This change is assigned to the Next Release release milestone and is not necessarily available in the latest downloadable desktop release yet. It is currently marked as status: pending release until a packaged release containing it is published.

  4. added a commit that references this issue on Oct 31, 2026
    9a66b0e
  5. EtienneLescot commented on Oct 31, 2026

    @EtienneLescot
    MemberAuthor

    Moved into v2.2.0 as part of the pre-release cut.

  6. added a commit that references this issue on Nov 1, 2026
    b4432a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    status: fixed in mainWork is merged into main but may not be in a downloadable release yet.status: pending releaseMerged change is waiting for a packaged desktop release.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions