Repository navigation
Conversation
…tion prelude The stencil-generated shared.graphql imports both directives from the Apollo Federation v2.3 subgraph spec. The federation prelude did not define them, so setting graphql.lint.federation to v2.3 failed with "imports @interfaceObject, which devbase's federation v2.3 prelude does not define" in every repo that carries that file. Add both directives, with the signatures from the Apollo Federation subgraph specification. Assisted-By: claude-sonnet 5.5 via opencode
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
malept
marked this pull request as ready for review
October 24, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Setting
graphql.lint.federation: v2.3fails on the generatedshared.graphqlwithimports @interfaceObject, which devbase's federation v2.3 prelude does not define. That file imports both@interfaceObjectand@composeDirectivefrom the Apollo Federation spec, and the prelude defined neither.Add both, using the signatures from the subgraph specification.
Jira ID
DT-5639
Notes for your reviewers
The prelude still rejects directives added in later spec versions, such as
@authenticated, by name instead of guessing a signature.Rejected review findings and intentional non-goals
These were raised in earlier reviews and deliberately left as they are. Do not raise them again unless the reasoning below no longer holds.
Rejected findings
Intentional behavior
@authenticated,@requiresScopes,@policy,@context,@fromContext) are rejected by name on purpose. Their signatures have not been verified against this prelude.supportedFederationVersions.nameargument of@composeDirectiverefers to a defined directive is a composition rule, not something this linter checks.