fix(sync): Destroy condition variables - #2004
Open
jpnurmi wants to merge 3 commits into
Open
Conversation
Add cross-platform condition-variable cleanup and invoke it when thread pools, background workers, flush tasks, and app-hang monitors are released. Condition variables may own implementation-specific resources, and POSIX requires destroying an initialized condition variable before reinitializing it. Close the semaphore and event handles owned by the pre-Vista emulation. Update synchronization tests to clean up their condition variables. Keep the task-queue notification under its predicate mutex so teardown cannot race with an in-flight signal.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2004 +/- ##
==========================================
+ Coverage 74.41% 74.42% +0.01%
==========================================
Files 104 104
Lines 25913 25922 +9
Branches 4691 4691
==========================================
+ Hits 19282 19293 +11
+ Misses 5299 5298 -1
+ Partials 1332 1331 -1 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cross-platform condition-variable cleanup and invoke it when thread pools, background workers, flush tasks, and app-hang monitors are released.
Condition variables may own implementation-specific resources, and POSIX requires destroying an initialized condition variable before reinitializing it. Close the semaphore and event handles owned by the pre-Vista emulation.
Update synchronization tests to clean up their condition variables. Keep the task-queue notification under its predicate mutex so teardown cannot race with an in-flight signal.