Repository navigation
Conversation
When an input file cannot be parsed as the expected format or has no sops metadata, say so in the error message instead of only reporting the parser error. Fixes getsops#258 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #258
Running
sops -don a file that is not a sops file only reported the parser error (for exampleCould not unmarshal input data: invalid character '#' looking for beginning of value), which gives no hint about the actual problem.Changes:
(is the file a sops-encrypted file in the expected format?).sops.MetadataNotFoundnow readssops metadata not found: the file does not appear to be encrypted with sops. The value is still the same constant, soerr == sops.MetadataNotFoundchecks (e.g. infilestatusand the store tests) are unaffected.Tests: added
cmd/sops/common/common_test.gocovering both cases.go test ./cmd/... ./stores/... .passes.