Repository navigation
hexagon: add SGN op - #30346
Merged
Merged
hexagon: add SGN op #30346
Conversation
Contributor
Author
|
@max-krasnyansky for visibility |
github-actions
Bot
added
ggml
kurquhar
force-pushed
the
kurquhar/hexagon-sgn
branch
from
October 23, 2026 01:01
1fa4ad4 to
ec99af2
Compare
kurquhar
marked this pull request as ready for review
October 23, 2026 01:02
Member
|
@kurquhar let's rebase with the latest fusion changes and remove that check (see comment in the code) |
kurquhar
force-pushed
the
kurquhar/hexagon-sgn
branch
from
October 23, 2026 13:57
ec99af2 to
dac32f8
Compare
Contributor
Author
|
@max-krasnyansky rebased and scalar fallback removed |
max-krasnyansky
force-pushed
the
kurquhar/hexagon-sgn
branch
from
October 23, 2026 17:57
bc447c2 to
bc68cba
Compare
Assisted-by: OpenCode
Assisted-by: OpenCode
…checks to apply to more conditions
max-krasnyansky
force-pushed
the
kurquhar/hexagon-sgn
branch
from
October 23, 2026 21:30
bc68cba to
9c5664e
Compare
max-krasnyansky
approved these changes
Oct 23, 2026
Member
|
@lhez for another review/ack |
max-krasnyansky
added
the
merge ready
lhez
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add SGN op to hexagon backend; motivated by Qwen3.8-Flash-Next (qwen4exp)
Additional information
New SGN op added. Only FP32 supported at this time, but could be extended to FP16, if needed.
Spills and other checks are clean in the new kernels.
Verification via test-backend-ops:
Requirements
Assisted-by: OpenCode