Skip to content

i18n: complete and fix Simplified Chinese (zh_CN) translation - #133

Merged
ericbsd merged 2 commits into
ghostbsd:masterfrom
wenyinos:i18n/complete-zh-cn
Nov 7, 2026
Merged

ericbsd merged 2 commits into
ghostbsd:masterfrom
wenyinos:i18n/complete-zh-cn

Conversation

@wenyinos

@wenyinos wenyinos commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Completes po/zh_CN.po against the current po/networkmgr.pot, and fixes several incorrect fuzzy translations.

msgfmt --statistics po/zh_CN.po before: 16 translated, 9 fuzzy, 24 untranslated.
After: 49 translated, 0 fuzzy, 0 untranslated.

What changed

  • Translate all 24 previously empty entries. Most of them belong to the Enterprise WPA / 802.1X credential dialog added in Add Enterprise WPA (802.1X/EAP) support #119, plus the connection-failure messages.
  • Remove the fuzzy flag from the header and from every entry, so the translations actually take effect at runtime.
  • Correct fuzzy translations that were wrong, not just unconfirmed:
    • Restart Networking was "禁用网络" (Disable networking) -> "重启网络"
    • Forget Network was "以太网" (Ethernet) -> "忘记网络"
    • Wired %s Disabled was "WiFi %s 已禁用" -> "有线 %s 已禁用"
    • %s Connected / %s Disconnected (WireGuard) had "WiFi" baked into the string -> removed
    • Disable %s was just "禁用", dropping the %s -> "禁用 %s"
    • Disconnect from %s used past tense -> "断开与 %s 的连接"
  • Drop obsolete #~ entries left over from an older string set.
  • Update header metadata (Project-Id-Version: networkmgr 7.0, revision date, language team). Original translator credit is kept.

Validation

  • msgfmt --check --statistics po/zh_CN.po -> 49 translated messages, no warnings (also checks all %s / %(name)s placeholders).
  • msgmerge --no-fuzzy-matching po/zh_CN.po po/networkmgr.pot leaves 0 fuzzy and 0 untranslated entries.
  • The msgid set matches a POT freshly generated from the current sources with xgettext; the checked-in POT is up to date.

Only po/zh_CN.po is touched. No code changes.

Summary by Sourcery

Complete and correct the Simplified Chinese translation catalog for the current network manager message set.

Bug Fixes:

  • Correct inaccurate Simplified Chinese translations for networking actions, connection states, wired networking, and WireGuard messages while preserving format placeholders.

Enhancements:

  • Complete the Simplified Chinese translation for all current network manager messages and remove obsolete entries and fuzzy markers.

Tests:

  • Validate the translation catalog against the current template with msgfmt and msgmerge, confirming all messages are translated without warnings or fuzzy entries.

Chores:

  • Refresh Simplified Chinese translation metadata while retaining the original translator credit.

Translate all 49 msgids from the current POT, remove the fuzzy flag from the header and entries, and correct wrong fuzzy translations (Restart Networking, Forget Network, Wired/WiFi status labels, disconnect action). Validate with msgfmt --check.
@sourcery-ai

sourcery-ai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

UI

Complete and correct the Simplified Chinese translations so current messages are active and accurately presented to users.

  • po/zh_CN.po L1-13, L21-37, L184-244 (+13 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ericbsd

ericbsd commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for completing the translation. Two small wording suggestions:

  1. trayicon.py:835: 信号较弱通常是最常见的原因。 reads as "usually the most common cause", which is redundant. Suggest:

    "最常见的原因是信号较弱。"
    
  2. trayicon.py:1054: 内层认证: uses 认证 while every other string uses 身份验证. For consistency, suggest:

    msgstr "内层身份验证:"
    

@wenyinos

wenyinos commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Both suggestions applied in 26af044: 信号较弱通常是最常见的原因。 → 最常见的原因是信号较弱。, and 内层认证: → 内层身份验证:. msgfmt --check --statistics still reports 49 translated, 0 fuzzy, 0 untranslated.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

@ericbsd ericbsd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from To triage to In review in NetworkMGR Issue Traker Nov 7, 2026
@ericbsd
ericbsd merged commit 2c7501f into ghostbsd:master Nov 7, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In review to Done in NetworkMGR Issue Traker Nov 7, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Done in Development Tracker Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants