Repository navigation
Drop NONE and NOASSERTION when combining declared licenses - #75
Merged
Merged
Conversation
spdx v0.3.6 rejects them inside compound expressions, so a manifest listing MIT and NOASSERTION produced an empty expression. Bump spdx and drop them when other licenses are declared.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spdx v0.3.6 rejects
NONEandNOASSERTIONinside compound expressions (git-pkgs/spdx#41), so a manifest listingMITandNOASSERTIONnow normalizes to an empty expression. Before the bump the output wasMIT AND NOASSERTION/MIT OR NOASSERTION, which is not valid SPDX either.This bumps spdx to v0.3.6 and drops
NONEandNOASSERTIONwhen other licenses are declared, so the example above givesMIT. A loneNONEorNOASSERTIONis kept.