Repository navigation
feat(but-ui-react): fail when a design note names something that's gone - #17179
Merged
Merged
Conversation
A rename leaves a note pointing at nothing, and nobody notices until an agent builds from it. check-notes.mjs runs in the library's check and looks at what but-ui's notes and the library's name in code: tokens, components, the library's own CSS variables, files, text classes and props, plus the links between notes. A note's 🍑 But UI nodes are checked too when FIGMA_API_KEY and FIGMA_FILE_KEY are set, as when pulling tokens. It found one already: the toasts note pointed at the snackbar's old Figma node, 1706-1682, which no longer exists. It now names the Snackbar component set, 2210-1708.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 5, step 3: a rename that leaves a note pointing at nothing now fails
pnpm check.scripts/check-notes.mjschecks what the notes name in code (tokens, components, the library's CSS variables, files, text classes, props) and the links between notesFIGMA_API_KEYandFIGMA_FILE_KEYset, as when pulling tokens