Skip to content

Commit b81c919

Browse files
jketemaCopilot
andcommitted
Explain Kotlin warning mode compatibility patch
Document why javac warning propagation must stay separate: on JDK 25 the Java 8 target's obsolete options warnings otherwise become fatal under Kotlin warn=error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent d309b84 commit b81c919

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎misc/bazel/registry/modules/rules_kotlin/2.4.21-codeql.1/patches/codeql_do_not_propagate_kotlin_warning_mode_to_javac.patch‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1-
Keep Kotlin warning settings scoped to Kotlin compilation. In particular, do not
2-
turn javac warnings into errors when Kotlin's warn = "error".
1+
rules_kotlin 2.4 propagates the Kotlin warning mode to javac, so the extractor's
2+
Kotlin warn = "error" setting also makes Java warnings fatal. This breaks the
3+
Java 8 target with JDK 25's obsolete source/target option warnings. Keep Kotlin
4+
warnings-as-errors for Kotlin compilation without changing javac warning behavior.
35
--- a/kotlin/internal/jvm/compile.bzl
46
+++ b/kotlin/internal/jvm/compile.bzl
57
@@ -1162,21 +1162,6 @@

‎misc/bazel/registry/modules/rules_kotlin/2.4.21-codeql.1/source.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"patches": {
55
"codeql_add_language_version_option.patch": "sha256-ml0fzhPwNozMi6yKtEn9YLM8LSQE4BWiimdwYzennCo=",
66
"codeql_do_not_emit_jdeps.patch": "sha256-yoBFnSWJyeF+gyhX+03TMTnRxUQJjup/f/KORdxVsAE=",
7-
"codeql_do_not_propagate_kotlin_warning_mode_to_javac.patch": "sha256-IWR4wEbHNEcaAAwFnZA2uHy99kviyuLr5mjzc1TOTMs="
7+
"codeql_do_not_propagate_kotlin_warning_mode_to_javac.patch": "sha256-TvfKfINvi1/tcLq3HDUs2doD4kr8AkMv0nsZvUHPjwg="
88
},
99
"patch_strip": 1
1010
}

0 commit comments

Comments
 (0)