Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The change can multiply read candidates across unrelated receiver types and drop valid data flow when only some receiver alternatives resolve to fields.
2 open issues
What changed in this PR
Updates Unified’s data-flow model to distinguish fields using type-inferred declarations, while retaining name-based fallback and compatibility with flow summaries.
Changes:
- Adds resolved-field content and name-based read compatibility.
- Routes qualified and implicit member reads and stores through field resolution.
- Adds Swift regression cases, a field-read summary model, and updated expected output.
| File | Description |
|---|---|
unified/ql/test/library-tests/dataflow/test.ext.yml |
Adds a name-based field-read flow summary. |
unified/ql/test/library-tests/dataflow/test.expected |
Updates expected flow paths for the changed model and new cases. |
unified/ql/test/library-tests/dataflow/fields.swift |
Covers resolved, inherited, unresolved, and summarized field accesses. |
unified/ql/lib/codeql/unified/internal/dataflow/DataFlowGraph.qll |
Uses resolved content for member reads and stores. |
unified/ql/lib/codeql/unified/internal/dataflow/Content.qll |
Introduces resolved-field identities, fallback selection, and name-based compatibility. |
Review effort: Max
hvitved
force-pushed
the
hvitved-unified-field-resolution
branch
2 times, most recently
from
November 2, 2026 19:20
4dbff80 to
71419e1
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
hvitved
force-pushed
the
hvitved-unified-field-resolution
branch
from
November 3, 2026 12:42
6524f1a to
2797f96
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name-based member content conflates unrelated fields with the same name. Use field resolution from type inference where available to distinguish resolved fields, while retaining name-based fallback for unresolved accesses and compatibility with flow summaries.