Repository navigation
Improve sample book collection validation and search - #236
Closed
MarcelloGasbarro wants to merge 1 commit into
Closed
MarcelloGasbarro wants to merge 1 commit into
MarcelloGasbarro wants to merge 1 commit into
Conversation
Add custom data-file support, validate new book details, and allow partial case-insensitive author searches across sample implementations. Add regression tests and apply Markdown formatting updates to the context chapter. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
samples/book-app-project/books.py |
Collaborator
|
Thanks @MarcelloGasbarro. The code is designed to have areas for improvement so that reviews and other tasks run throughout the course can show details about improvements that can be made. Appreciate the PR but we aren't planning to update the code right now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The book collection samples currently accept incomplete book details and require exact author-name matches, making common searches such as
Tolkienfail forJ.R.R. Tolkien. This updates the sample implementations so they validate new book data, support case-insensitive partial author searches, and accept custom data-file paths in Python.Adds regression tests for author search and input validation in Python and JavaScript. The context chapter also contains Markdown formatting updates. Python and JavaScript tests pass; the C# test suite could not run because the available .NET 9 SDK cannot target the project's .NET 10 framework.