Repository navigation
fix(course-updater): allow scoped GitHub web fetching - #237
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The scoped permission is correctly propagated without unrelated functional changes.
Review effort: Balanced
Findings: None
What changed in this PR
Adds scoped GitHub URL approval so Course Updater’s existing web-fetch tool can access the Copilot CLI changelog.
Changes:
- Configures the Copilot engine with
--allow-url=https://github.com. - Regenerates the locked workflow with the scoped permission and updated metadata.
| File | Description |
|---|---|
.github/workflows/course-updater.md |
Adds scoped engine URL approval. |
.github/workflows/course-updater.lock.yml |
Propagates the permission into the generated workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add
engine.id: copilotandengine.args: ["--allow-url=https://github.com"]to Course Updater. Theweb-fetchtool was enabled, but Copilot also requires URL approval.safe-outputs.allowed-domainsdoes not grant fetch permission.Only
.github/workflows/course-updater.mdand.github/workflows/course-updater.lock.ymlchange. The generated lock includes the scoped URL permission and new metadata hashes. The existing tools, prompts, schedule, labels, action pins, firewall, compiler version (v0.68.1), and Copilot CLI version (1.0.21) remain unchanged. No unrestricted permission is added.Verification
Compiled only Course Updater with the official
gh-aw v0.68.1release binary. Verified its SHA-256 checksum before use. An exact comparison confirmed that only the URL permission and generated metadata changed. Existing action pins were preserved after compilation.Course Updater run 37281737127 tested commit
4f245e25c8015ceb9e31f86718b2da06095bdc17on this branch. The run completed withsuccess. All five jobs passed: activation, agent, detection, safe_outputs, and conclusion.The actual
web-fetchcall succeeded forhttps://github.com/github/copilot-cli/blob/main/changelog.md. Theagentartifact contains this result inagent-stdio.log, lines 105-106:The tool returned a
Contents ofresult, not a URL permission denial. This check used the actual tool result, not only the Actions conclusion. Existing restrictions remain in effect; an unrelatedgit clonerequest was still denied.The same scoped permission was verified in github/copilot-app-for-beginners run 37279532734.