Skip to content

Fix CI - #10

Merged
composerinteralia merged 6 commits into
githubfrom
ci
Oct 14, 2025
Merged

composerinteralia merged 6 commits into
githubfrom
ci

Conversation

@composerinteralia

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings October 14, 2025 15:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes continuous integration (CI) issues by updating Ruby versions, adding missing dependencies, and fixing test compatibility problems.

  • Updates Ruby version from 2.5/3.0 to 3.4 in CI configuration
  • Adds ostruct gem dependency to resolve missing library issues
  • Fixes hash syntax and regex patterns for Ruby compatibility
  • Prevents killall command from running in CI environment

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/ci.yml Updates Ruby version matrix to use 3.4 instead of 2.5 and 3.0
Gemfile Adds ostruct gem dependency
test/setup.rb Conditionally skips killall command in CI environment
test/unit/rails_test.rb Fixes hash syntax and regex pattern for Ruby compatibility
test/unit/memcached_test.rb Updates test assertions and regex pattern for Ruby compatibility
test/unit/memcached_experimental_test.rb Fixes regex pattern for Ruby compatibility

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/unit/rails_test.rb
Comment thread test/unit/memcached_test.rb
Comment thread test/unit/memcached_experimental_test.rb
@composerinteralia
composerinteralia merged commit f069720 into github Oct 14, 2025
6 checks passed
@composerinteralia composerinteralia mentioned this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants