Repository navigation
Fix CI - #10
Merged
Merged
Fix CI#10
Conversation
These were failing because they relied on caller locations for keys and those changed between Ruby versions
There was a problem hiding this comment.
Pull Request Overview
This PR fixes continuous integration (CI) issues by updating Ruby versions, adding missing dependencies, and fixing test compatibility problems.
- Updates Ruby version from 2.5/3.0 to 3.4 in CI configuration
- Adds ostruct gem dependency to resolve missing library issues
- Fixes hash syntax and regex patterns for Ruby compatibility
- Prevents killall command from running in CI environment
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Updates Ruby version matrix to use 3.4 instead of 2.5 and 3.0 |
| Gemfile | Adds ostruct gem dependency |
| test/setup.rb | Conditionally skips killall command in CI environment |
| test/unit/rails_test.rb | Fixes hash syntax and regex pattern for Ruby compatibility |
| test/unit/memcached_test.rb | Updates test assertions and regex pattern for Ruby compatibility |
| test/unit/memcached_experimental_test.rb | Fixes regex pattern for Ruby compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.