Repository navigation
feat(starter): add approval-gated feedback proposals - #67
Merged
Merged
Conversation
Carry reviewed Hub findings into private, evidence-backed guidance proposals and require explicit approval before applying changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1330930d-35a8-45e7-96a5-d3e7ff06797a
There was a problem hiding this comment.
🔵 Needs a closer look
Proposal preparation and approval-gated application still need end-to-end human validation, and the artifact-validation rules remain inconsistent.
1 open issue
What changed in this PR
Adds an approval-gated path from Hub feedback to reusable guidance in prototype repositories, addressing #60 while keeping review evidence private.
Changes:
- Saves structured review evidence and offers stable finding IDs for investigation.
- Adds proposal preparation, exact edit previews, explicit approval and target rechecks before applying guidance changes.
- Documents the workflow and includes the new skill in starter-copy checks.
| File | Description |
|---|---|
starter/README.md |
Explains the feedback-to-guidance workflow and its limits. |
starter/.agents/skills/review-hub-feedback/SKILL.md |
Adds private artifact saving and finding selection. |
starter/.agents/skills/review-hub-feedback/references/handoff.md |
Defines private storage and review-record requirements. |
starter/.agents/skills/prepare-feedback-proposals/SKILL.md |
Defines guidance investigation, proposal previews and approval. |
starter/.agents/skills/prepare-feedback-proposals/references/apply.md |
Defines approved-edit checks and partial-failure reporting. |
scripts/create-prototype-repo.test.mjs |
Adds the proposal skill to starter-copy expectations. |
Review effort: Max
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1330930d-35a8-45e7-96a5-d3e7ff06797a
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prototype authors need a path from recurring Hub feedback to better repository guidance without letting a request to investigate authorize edits.
Closes #60
What changes
The read-only
/review-hub-feedbackskill saves evidence and independent judgments in a private review artifact, then asks which findings the user wants investigated. The new/prepare-feedback-proposalsskill compares selected findings with existing guidance and shows exact proposed changes before requesting approval. Findings may instead be already covered, need clarification, or warrant a separate environment investigation.Only explicitly approved guidance changes are applied. Conflicting proposals and changed target files require renewed review. Prototype fixes, environment changes and Hub learning decisions stay outside this workflow; private evidence stays out of tracked files. The starter guide explains the flow, and existing copy checks include the new skill.
The fresh-session trial confirmed skill discovery and reached finding selection. Proposal preparation and approval-gated application have not yet been verified end to end.