Repository navigation
Conversation
Assisted-by: Codex (model: GPT-6, autonomous)
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The minimal fix matches the documented contract, with coverage for preserving handlers and explicitly disabling them.
No open issues 🎉
What changed in this PR
Fixes #5092 by preventing incomplete integration overrides from silently removing Spec Kit’s built-in and extension event hooks.
Changes:
- Treats a missing
eventsfield as invalid, preserving existing handlers and logging a warning. - Adds regression cases for empty entries and misspelled keys; explicit
events: {}still disables hooks.
Validation relied on source inspection and the supplied regression evidence; tests were not rerun.
| File | Description |
|---|---|
| tests/specify_cli/events/test_events.py | Adds regression coverage for preserving both handler layers and logging warnings. |
| src/specify_cli/events/__init__.py | Stops defaulting a missing events field to an empty override. |
Review effort: Max
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5092. An integration override such as
claude: {}or one with a misspelledevntskey currently acts asevents: {}, silently removing every existing event hook during an upgrade.Treat a missing
eventsfield like the other invalid, non-mapping values: warn and preserve the built-in and extension handlers. An explicitly suppliedevents: {}still disables hooks. This matches the documented override contract and the existing validation comment.Testing
uv sync --extra test.Windows / Python 3.14.6:
.venv/Scripts/python -m pytest tests/specify_cli/events -q: 211 passed, 5 skipped, 4 failed. All four failures occur atos.symlinkin existing fixture setup because this Windows environment lacks symlink privileges (WinError 1314), before the changed resolver is called. Existing explicit-empty override tests pass. The full repository suite was not run.integration upgrade claude --force. Both invalid overrides preserve the generatedsettings.jsonhooks unchanged. A subsequent explicitevents: {}removes them. The test does not invoke Claude or a live model; it exercises the CLI and generated native configuration.git diff --checkpasses.AI Disclosure
AI disclosure: OpenAI Codex (GPT-6), operating autonomously on behalf of Shubham-Padkonde, investigated the issue, generated the fix and regression tests, ran validation, and drafted this PR. The exact model variant/reasoning setting is not exposed to the agent. No personal line-by-line human review is claimed.