Skip to content

chore: pin Node.js with .nvmrc - #60

Merged
setchy merged 1 commit into
mainfrom
chore/add-nvmrc
Oct 28, 2026
Merged

setchy merged 1 commit into
mainfrom
chore/add-nvmrc

Conversation

@setchy

@setchy setchy commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

Adds .nvmrc pinned to 24.22.1 — the same development version used in gitify, website, and electron-menubar — and points the CI setup-vp steps at it.

This repo's only runtime pin is currently devEngines.runtime in package.json, so nvm/fnm/asdf users have no local version file, and CI lets Vite+ resolve Node without an explicit pin.

  • .nvmrc: 24.22.1
  • .github/workflows/ci.yml: add node-version-file: .nvmrc to both voidzero-dev/setup-vp steps

Verification

  • nvm use resolves to v24.22.1
  • CI lint/bundle jobs install the pinned version via setup-vp

@setchy
setchy requested a review from afonsojramos as a code owner October 28, 2026 11:34
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy merged commit e522959 into main Oct 28, 2026
8 checks passed
@setchy
setchy deleted the chore/add-nvmrc branch October 28, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant