Skip to content

chore: enable Node.js devEngines validation - #61

Merged
setchy merged 1 commit into
mainfrom
chore/add-devengines
Oct 28, 2026
Merged

setchy merged 1 commit into
mainfrom
chore/add-devengines

Conversation

@setchy

@setchy setchy commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

Declares the exact Node.js development runtime in devEngines.runtime, alongside the existing .nvmrc and engines.node:

  • .nvmrc — provisions the version for nvm/fnm/mise and actions/setup-node
  • engines.node — supported range (>=24) for consumers and package managers
  • devEngines.runtime — machine-readable exact pin (24.22.1) that npm/pnpm validate

onFail is set to "warn", so a mismatched runtime produces a warning rather than blocking installs or adding a project-local runtime to pnpm-lock.yaml.

The existing devEngines block had no onFail, which pnpm ignores entirely — a deliberately wrong version installed without complaint. Adding "warn" makes it actually validate.

Verification

  • pnpm install on Node 24.22.1 → no warning
  • pnpm install / npm install on a mismatched Node → warning (tested with pnpm 12.15 and npm 12.2)
  • pnpm-lock.yaml unchanged

@setchy
setchy requested a review from afonsojramos as a code owner October 28, 2026 11:47
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy merged commit d6e68c4 into main Oct 28, 2026
8 checks passed
@setchy
setchy deleted the chore/add-devengines branch October 28, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant