update crates-sync - #2173
Conversation
Map campsite_user_id from commit bindings through the synced member map so history, detail, and latest-commit UI show github/username instead of raw public ids.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96e94bccba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| crate_name, | ||
| v, | ||
| dl_base_url, | ||
| readonly_cache=readonly_crate_cache, |
There was a problem hiding this comment.
When --readonly-crate-cache accepts an archive that passes _crate_file_seems_valid but later fails extraction, process_crate_version still unconditionally calls _try_remove_file(crate_path) at lines 905-908. For example, a nonempty tarball with an unexpected top-level layout passes the new readonly precheck and is then deleted after extraction fails, corrupting the freighter-owned shared cache despite the option's promise to never delete from it. Propagate the readonly state into processing and suppress this cleanup in readonly mode.
Useful? React with 👍 / 👎.
| const members = authors | ||
| .map((actor) => memberMap.get(actor) as SyncOrganizationMember | undefined) | ||
| .filter((m): m is SyncOrganizationMember => !!m) |
There was a problem hiding this comment.
For historical commits authored by a deactivated organization member, this map never contains the author because useMemberMap() calls useSyncedMembers() with its default includeDeactivated=false filter. The subsequent filter therefore permanently removes that author's avatar rather than merely waiting for member data; the same map-based resolution elsewhere falls back to an opaque campsite user ID. Resolve author identities from a member list that includes deactivated users.
Useful? React with 👍 / 👎.
2 participants
No description provided.