Skip to content

fix: format float timezone offsets as integer fields #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Byron merged 1 commit into from
Oct 29, 2026
Merged

fix: format float timezone offsets as integer fields #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions git/objects/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ def altz_to_utctz_str(altz: float) -> str:
:param altz:
Timezone offset in seconds west of UTC.
"""
hours = abs(altz) // 3600
minutes = (abs(altz) % 3600) // 60
hours, minutes = divmod(int(abs(altz) // 60), 60)
sign = "-" if altz >= 60 else "+"
return "{}{:02}{:02}".format(sign, hours, minutes)

Expand Down
11 changes: 11 additions & 0 deletions test/test_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,17 @@ def __repr__(self):
return f"{type(self).__name__}({self.name!r})"


@pytest.mark.parametrize(
"offset, expected",
[(0.0, "+0000"), (19800.0, "-0530"), (-19800.0, "+0530"), (34200.9, "-0930"), (60.1, "-0001"), (-59.9, "+0000")],
)
def test_altz_to_utctz_str_accepts_float_seconds(offset, expected):
result = altz_to_utctz_str(offset)
assert result == expected
assert verify_utctz(result) == result
assert utctz_to_altz(result) == utctz_to_altz(expected)


@ddt.ddt
class TestUtils(TestBase):
"""Tests for most utilities in :mod:`git.util`."""
Expand Down
Loading