Repository navigation
Add send_tree and dispatch_tree to support sending iodata - #59
JonasGruenwald wants to merge 1 commit into
Conversation
| /// Send a HTTP request of binary data using the default configuration. | ||
| /// | ||
| /// If you wish to use some other configuration use `dispatch_bits` instead. | ||
| /// If you wish to use some other configuration use `dispatch_tree` instead. |
There was a problem hiding this comment.
If this method is for sending a BitArray, I'd expect the docs to poing to dispatch_bits if the configuration is needed.
| /// Send a HTTP request of binary data with the `BytesTree` type using the default configuration. | ||
| /// | ||
| pub fn dispatch_bits( | ||
| /// If you wish to use some other configuration use `dispatch_bits` instead. |
There was a problem hiding this comment.
I'd expect this one to point to dispatch_tree.
| pub fn bytes_tree_test() { | ||
| let body = | ||
| string_tree.new() | ||
| |> string_tree.append("Hello") |
There was a problem hiding this comment.
You can use bytes_stree.append_string here and avoid the conversion at the end by starting with a BytesTree.
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## v5.1.0 - 2026-??-?? | |||
There was a problem hiding this comment.
Should probably be in a section called Unreleased.
b72d5d0 to
8ce404e
Compare
|
@jtdowney thanks for having a look! |
|
|
||
| /// Configuration that can be used to send HTTP requests. | ||
| /// | ||
| /// To be used with `dispatch` and `dispatch_bits`. |
There was a problem hiding this comment.
Minor nit, but this doc should be updated to reference dispatch_tree.
There was a problem hiding this comment.
Ah true, good point, I've added it
8ce404e to
5c5831c
Compare
2 participants
Closes: #58
I can rewrite the test if #57 is merged before this.(Tests have been adjusted)