Repository navigation
Cleanup for CI - #61
Merged
Merged
Conversation
lpil
reviewed
Jul 24, 2026
| // let assert Ok(req) = request.to("https://ipv6.google.com") | ||
| // let assert Ok(resp) = httpc.send(req) | ||
| // assert 200 == resp.status | ||
| // } |
Member
There was a problem hiding this comment.
Do not remove tests please 馃檹 Without this we don't know if ipv6 functionality is working.
Member
Author
There was a problem hiding this comment.
CI won't pass with this test and hasn't since it was added, it is a bad test
Member
Author
There was a problem hiding this comment.
In 5c8ac22 I've enabled and noted it is expect to fail in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at some older PRs like #57 and noticed CI had been failing because of an outdated CI version for Gleam compared to stdlib. This also disables the IPv6 test as apparently GitHub actions can't support it (actions/runner-images#668). If #57 lands a test can be run against a loopback IPv6 only server.