file: quote keys using the write delimiter - #397
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Do not wrap key names in backticks just because they contain a parse-time extra delimiter such as ':'. Samba-style keys like fruit:metadata are valid when the write delimiter is '='. Fixes go-ini#355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys were quoted whenever they contained any parse-time delimiter (
KeyValueDelimiters, default=:). That wraps Samba-style names likefruit:metadatain backticks even though the write delimiter is=.Quote a key only if it contains the write delimiter or a double quote (or wrap keys that themselves contain backticks).
=in a key is still quoted.Fixes #355