Repository navigation
Skip queued callbacks after a group error - #17
Merged
Merged
Conversation
Coverage Report for CI Build 37111638545Coverage remained the same at 98.87%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
With
NewErrSizedGroup(1, TermOnErr), a callback waiting for capacity currently runs even after the active callback returns an error.The termination check now runs after semaphore acquisition, so queued callbacks see errors recorded while they were waiting.
Already running callbacks can still finish.
The regression reproduces the bug before the fix.
It covers both locking modes and execution without
TermOnErr, and checks that skipped callbacks release their permits.Verified on Go 1.23.4 with
TZ=America/Chicago go test -timeout=60s -race -covermode=atomic -coverprofile=profile.cov ./....The suite passes with 99.1% statement coverage. The new test passes 50 race runs.
go build -race ./...andgo vet ./...pass.golangci-lint run --timeout=3mreports zero issues.