Skip to content

feat: slovak translations - #258

Merged
JoeSouthan merged 10 commits into
gocardless:masterfrom
martinbarilik:add-slovak-translations
Sep 29, 2026
Merged

feat: slovak translations#258
JoeSouthan merged 10 commits into
gocardless:masterfrom
martinbarilik:add-slovak-translations

Conversation

@martinbarilik

@martinbarilik martinbarilik commented Feb 26, 2025

Copy link
Copy Markdown

Slovak translations ready to be merged.

Have a nice day !

@martinbarilik

martinbarilik commented Feb 10, 2026

Copy link
Copy Markdown
Author

Hi, is there a reason the PR is not merged already ? :-)

if so, feel free to let me know, i'll do what. need this

thanks

JoeSouthan
JoeSouthan reviewed Sep 28, 2026
View reviewed changes

@JoeSouthan JoeSouthan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this review was written by Claude (an AI assistant), posted on behalf of @JoeSouthan.

Thanks for adding Slovak, looks good overall. A few suggestions below, based on how the other locales in config/locales/ handle the same keys. You'll know Slovak far better than me, so please treat the wording as questions rather than corrections.

One non-translation point: the file was added with mode 100755. Could you change it to 100644 to match the other locale files?

Comment thread config/locales/sk.yml Outdated
Comment thread config/locales/sk.yml Outdated
Comment thread config/locales/sk.yml Outdated
Comment thread config/locales/sk.yml
Comment thread config/locales/sk.yml
martinbarilik and others added 4 commits September 29, 2026 07:31
@martinbarilik @JoeSouthan
Update config/locales/sk.yml
6e6a4cf 
Co-authored-by: Joe Southan <JoeSouthan@users.noreply.github.com>
@martinbarilik @JoeSouthan
Update config/locales/sk.yml
1756808 
Co-authored-by: Joe Southan <JoeSouthan@users.noreply.github.com>
@martinbarilik @JoeSouthan
Update config/locales/sk.yml
a0e4fba 
Co-authored-by: Joe Southan <JoeSouthan@users.noreply.github.com>
@martinbarilik
Update Slovak translation for failed_checksum_test
1717486
@martinbarilik

martinbarilik commented Sep 29, 2026

Copy link
Copy Markdown
Author

Hi, anything else ?

JoeSouthan
JoeSouthan reviewed Sep 29, 2026
View reviewed changes
Comment thread config/locales/sk.yml
martinbarilik and others added 2 commits September 29, 2026 11:34
@martinbarilik @JoeSouthan
Update config/locales/sk.yml
a2fc818 
Co-authored-by: Joe Southan <JoeSouthan@users.noreply.github.com>
@martinbarilik
Add Slovak (sk) to supported locales
c462e84
@martinbarilik

martinbarilik commented Sep 29, 2026

Copy link
Copy Markdown
Author

Hope its all ;)

JoeSouthan
JoeSouthan approved these changes Sep 29, 2026
View reviewed changes

@JoeSouthan JoeSouthan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution and apologies for the delay in reviewing.

@JoeSouthan
JoeSouthan enabled auto-merge (squash) September 29, 2026 09:38
@JoeSouthan
JoeSouthan merged commit 3a839b1 into gocardless:master Sep 29, 2026
4 checks passed
@JoeSouthan JoeSouthan mentioned this pull request Sep 29, 2026
Merged
JoeSouthan added a commit that referenced this pull request Sep 29, 2026
@JoeSouthan
Bump version to 1.36.0 (#278)
4049312 
Release 1.36.0 with changes since v1.35.0:

- Add Slovak translations (#258)
- Update German translation for invalid check digits (#267)
- Drop CI testing for Rubies older than 3.3 (#277)

The gc_ruboconfig bump (#271) is dev-only and omitted from the
changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeSouthan JoeSouthan JoeSouthan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martinbarilik @JoeSouthan