Skip to content

Update translation for invalid checksum - #267

Merged
JoeSouthan merged 1 commit into
gocardless:masterfrom
digineo:fix-translation
Sep 29, 2026
Merged

JoeSouthan merged 1 commit into
gocardless:masterfrom
digineo:fix-translation

Conversation

@dmke

@dmke dmke commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

The previous translation for invalid_check_digits was something like:

Check digits did not pass sum test. (01 digits expected, 02 received).

This PR updates the wording (and punctuation) to something akin to:

Check digits are invalid (01 expected, 02 received).

N.B. I'm a native German speaker.

Comment thread config/locales/de.yml Outdated
ibandit:
invalid_country_code: "'%{country_code}' ist kein gültiges IBAN-Länderkennzeichen gemäß ISO 3166-1"
invalid_check_digits: "Prüfziffer hat Betragsprüfung nicht bestanden. (%{expected_check_digits} Zeichen erwartet, %{check_digits} angegeben)."
invalid_check_digits: "Prüfziffer ist ungültig (%{expected_check_digits} erwartet, %{check_digits} angegeben)."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a German speaker so got Claude to have a read!

It's suggesting that ist is singular and to use sind as there are 2 check digits in an IBAN.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, technically pl. "check digits" is "Prüfziffern", but s. "Prüfziffer" can refer to a group of digits. Both are correct:

  • "Prüfziffer ist ungültig"
  • "Prüfziffern sind ungültig"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strike that. The official German term for "check digits" is "Prüfsumme", so:

  • "Prüfsumme ist ungültig"

I'll update the commit.

@JoeSouthan JoeSouthan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JoeSouthan
JoeSouthan enabled auto-merge (squash) September 29, 2026 08:56
@JoeSouthan
JoeSouthan merged commit b3bdbaf into gocardless:master Sep 29, 2026
4 checks passed
JoeSouthan added a commit that referenced this pull request Sep 29, 2026
Release 1.36.0 with changes since v1.35.0:

- Add Slovak translations (#258)
- Update German translation for invalid check digits (#267)
- Drop CI testing for Rubies older than 3.3 (#277)

The gc_ruboconfig bump (#271) is dev-only and omitted from the
changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants