Rebuild production WASM during deploy to fix stale barrel bug - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8.
The barrel gameplay path in Flow matches vanilla Doom, but the deployed Pages artifact could remain stale after compiler/build fixes. In particular,
site/wasm/doom/doom.wasmhad been rebuilt while the now-removed unsound LLVM annotation pass was active, and the Pages workflow later uploaded that checked-in artifact without rebuilding it.This changes Pages to checkout Flow, build the production MLIR WASM from the commit being deployed, smoke-test that exact artifact, and only then upload
site/. It also adds the requested README postmortem explaining why C-vs-MLIR CRC parity did not catch the failure: backend agreement does not prove vanilla semantic equivalence, and it did not validate the independently checked-in production artifact.The intended invariant after this PR is that production is derived from current source, not from whichever WASM binary happens to be committed under
site/.