Fix looking for extension_api.json with custom gdextension_dir - #2052
Merged
Conversation
Ivorforce
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to be possible to specify
scons gdextension_dir=PATHwherePATHcontains files namedextension_api.jsonandgdextension_interface.json, but I broke it in #2034 by making it always include theapi_versionin the path (likeextension_api-4-7.json). However, it should really only use theapi_versionwhen looking for the bundled JSON files, not when using a custom directoryThis PR makes it so that it looks for
extension_api.jsonwhen the user gives a customgdextension_dir