Skip to content

Fix conditional method typing #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushi806 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix conditional method typing #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/galaxy/api/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,21 +238,21 @@ def wrap_result(result):
return result

if immediate:
def method(*args, **kwargs):
def sync_method(*args, **kwargs):
result = handler(*args, **kwargs)
return wrap_result(result)

self._connection.register_method(name, method, True, sensitive_params)
self._connection.register_method(name, sync_method, True, sensitive_params)
else:
async def method(*args, **kwargs):
async def async_method(*args, **kwargs):
if not internal:
handler_ = self._wrap_external_method(handler, name)
else:
handler_ = handler
result = await handler_(*args, **kwargs)
return wrap_result(result)

self._connection.register_method(name, method, False, sensitive_params)
self._connection.register_method(name, async_method, False, sensitive_params)

def _register_notification(self, name, handler, internal=False, immediate=False, sensitive_params=False):
if not internal and not immediate:
Expand Down