Fix HTTP replay settlement and cancellation with unobserved trailers - #3857
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a08615-324b-76fb-883a-9fa3472a5e3a Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
✅ Deploy Preview for golemcloud canceled.
|
Amp-Thread-ID: https://ampcode.com/threads/T-01a08ad5-52d3-773d-92fc-a775a25c119f Co-authored-by: Amp <amp@ampcode.com>
…nto fix/http-replay-tail-main
Amp-Thread-ID: https://ampcode.com/threads/T-01a08ad5-52d3-773d-92fc-a775a25c119f Co-authored-by: Amp <amp@ampcode.com>
…nto fix/http-replay-tail-main
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
noise64
approved these changes
Sep 11, 2026
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08a69-6105-72cf-ba03-88fb0edac37d Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Resolves GOL-485
Markerless HTTP trailers completion waits for the recorded replay tail to finish, but its active background-task token prevents invocation settlement from returning to consume the remaining history. Park only the passive replay-progress notification after the owned cursor transaction completes. Queued/running cursor transactions and marker-bearing delivery barriers stay active.
A second real cancellation case requires acknowledging the cancelled body after durable body/span finalization but before the markerless trailers wait. Otherwise the guest cannot return to advance the replay tail. Recorded delivery ordering remains intact.
Real before/after evidence
0-a/1-b.Both Rust cases verify the same markerless parent End before invocation finish, two restarts, exactly one network request, one disposition marker per child, and no marker for unobserved trailers. No artificial host gate is used. No Go SDK or Go test registration is included.
Validation
Depends on #3855, whose clock commit is included so CI tests the validated combination. Merge #3855 first; its changes then drop out of this PR's diff. The HTTP delta is two commits touching ten files and contains no snapshot changes. Broad CI remains to be verified.
Investigation: https://ampcode.com/threads/T-01a08615-324b-76fb-883a-9fa3472a5e3a