Repository navigation
Pass in-memory dataset as a dynamic JAX sampling argument - #380
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285.
Changes
sample_per_shard(data, key)and supply the device-resident dataset as a dynamic argument at each call. This avoids embedding the dataset as an XLA constant while retaining existing batching, RNG evolution, and sampling behavior.pmappath unchanged.dataandkeyarguments, then checks a real CPU JAX sample.Validation
(2, 3)shape with dataset size 8.python -m compileallon changed files: passed.ruff check --select E4,E7,E9,Fon changed files: passed.git diff --check: passed.The full Acme TensorFlow/TFDS integration test suite and GPU memory behavior were not exercised locally; maintainers should confirm them in CI or a suitable runtime.