Skip to content

Report inverse-kinematics residuals at the returned configuration - #565

Open
Afloat16 wants to merge 1 commit into
google-deepmind:mainfrom
Afloat16:fix-final-ik-residual
Open

Afloat16 wants to merge 1 commit into
google-deepmind:mainfrom
Afloat16:fix-final-ik-residual

Conversation

@Afloat16

@Afloat16 Afloat16 commented Oct 7, 2026

Copy link
Copy Markdown

The inverse-kinematics loop measures the residual before applying an update. At the iteration limit, it can return an updated configuration with the preceding residual and success flag. Recompute the same weighted position/quaternion norm at the returned configuration so the diagnostic and convergence classification describe the actual result.

Preserves the solver, damping, progress termination, iteration count and inplace/copy behavior. Adds seven regression methods covering last-step translation, rotation and combined-pose convergence, clipped and regularized updates, an already converged pose and progress termination. The position and planar-angle references are computed independently from the final pose.

Validation: all 37 original inverse-kinematics cases pass in both versions. The same seven new methods give 5 failures before the repair and seven passes afterward. Generated the bindings from the unchanged canonical autowrap with genuine MuJoCo 3.15.0 headers; the tracked functions.py remains unchanged.

@google-cla

google-cla Bot commented Oct 7, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant