Preserve plateau scale dtype with array minimum scales - #1774
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array-like
min_scalevalues can promote the reduced scale above the dtype stored inReduceLROnPlateauState. The cooldown branches then return different dtypes, solax.condraises aTypeErroron the first update with float16 or bfloat16 parameters and a float32 minimum scale.Cast the result back to the existing scale dtype. Add coverage for NumPy/JAX minimum scales, mixed-precision parameter trees, accumulation, cooldown, and repeated reductions down to the floor, both eagerly and under JIT.
Validation
This is separate from the negative-metric comparison change in #1767.