Repository navigation
build(deps): drop the default features of rstest - #535
Merged
Merged
Conversation
cargo deny now rejects pin-utils as unmaintained (RUSTSEC-2026-0441), which fails the CI. pin-utils only comes in through futures-util, which rstest pulls in for its default async-timeout feature. No test is async and no crate renames rstest, so neither default feature is needed. Disabling them removes 13 packages from Cargo.lock, including futures-util and pin-utils. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Coverage Report for CI Build 42694681328Coverage increased (+0.03%) to 39.405%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo deny checknow rejectspin-utilsas unmaintained(RUSTSEC-2026-0441), which
fails the Rust workflow of every pull request.
pin-utilsonly comes in throughfutures-util, whichrstestpulls in for its defaultasync-timeoutfeature.No test is async and no crate renames
rstest, so neither default feature isneeded.
Disabling them removes 13 packages from
Cargo.lock, includingfutures-utiland
pin-utils.cargo +nightly fmt --check,cargo clippy --all-targets -D warningson x86_64-unknown-linux-gnu/musl, aarch64-unknown-linux-gnu andaarch64-apple-darwin, and
cargo test --workspacepass locally.