Skip to content

Make graphics_detector build on multiple platforms #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3405691582 merged 1 commit into from
Oct 28, 2026
Merged

Make graphics_detector build on multiple platforms #3441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions base/cvd/cuttlefish/host/graphics_detector/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ cf_cc_binary(
deps = [
":graphics_detector_cc_proto",
"//cuttlefish/host/graphics_detector/shaders:graphics_detector_shaders",
"//cuttlefish/posix:temp_failure_retry",
"@abseil-cpp//absl/log",
"@egl_headers",
"@opengl_headers//:GLES2_headers",
Expand Down
14 changes: 13 additions & 1 deletion base/cvd/cuttlefish/host/graphics_detector/subprocess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,23 @@
#include "cuttlefish/host/graphics_detector/subprocess.h"

#include <dlfcn.h>
#include <errno.h>
#include <poll.h>
#include <signal.h>
#include <string.h>
#include <sys/prctl.h>
#include <sys/wait.h>
#include <unistd.h>
#if defined(__linux__)
#include <sys/syscall.h>
#endif

#include <condition_variable>
#include <functional>
#include <mutex>
#include <thread>

#include "cuttlefish/posix/temp_failure_retry.h" // IWYU pragma: keep

namespace gfxstream {
namespace {

Expand All @@ -50,11 +56,17 @@ class ScopedCloser {
};

int PidfdOpen(pid_t pid) {
#if defined(__linux__)
// There is no glibc wrapper for pidfd_open.
#ifndef SYS_pidfd_open
constexpr int SYS_pidfd_open = 434;
#endif
return syscall(SYS_pidfd_open, pid, /*flags=*/0);
#else
(void)pid;
errno = ENOSYS;
return -1;
#endif
}

gfxstream::expected<Ok, std::string> WaitForChild(pid_t pid) {
Expand Down
Loading