Repository navigation
Conversation
added 2 commits
October 27, 2026 20:22
When the DiskArtifact message was introduced, it was enforced that it wasn't used in combination with other artifact fields. This removes that check to allow different combinations of mixing to occur. Bug: 546186358 Test: bazel test ...
The current behavior will use a signed build for certain builds (e.g.
`-user` builds). However, this prevents mixing with other build
artifacts because the target files are used for these builds, and
target files are unsigned. We detect if this mixing has been
requested, and if so, we stick with unsigned builds.
Bug: 546186358
Test: Confirm the following boots:
cvd create --config_file config.json
config.json contents:
{
"common": {
"host_package": "@ab/git_26Q4-release/cf_x86_64_auto-user"
},
"instances": [
{
"@import": "auto",
"disk": {
"default_build": "@ab/git_26Q4-release/cf_x86_64_auto-user",
"super": {
"system": "@ab/git_26Q4-release/gsi_car_x86_64-user"
}
}
}
]
}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up from the discussion in #3430
This lands two changes:
DiskArtifactsmessage from being used with the existing artifact fields (in this case, I'm particularly interested inSuper.system).